feat(shared): Introduce client-side caching for telemetry events#3267
feat(shared): Introduce client-side caching for telemetry events#3267LauraBeatris wants to merge 8 commits intoclerk:mainfrom LauraBeatris:add-client-cache-for-telemetry-events
Conversation
🦋 Changeset detectedLatest commit: 43d94bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| import type { TelemetryEventRaw } from '../types'; | ||
|
|
||
| const EVENT_METHOD_CALLED = 'METHOD_CALLED' as const; | ||
| const EVENT_SAMPLING_RATE = 0.1; |
There was a problem hiding this comment.
Also introducing a sampling rate lower than the default for this event, to handle the server-side scenarios.
CC @brkalow let me know if that makes sense
|
This PR also enables #3279 (adding telemetry to clerk-elements) |
| ); | ||
| } | ||
|
|
||
| const hasExpired = cacheEntry && now - cacheEntry > this.#cacheTtl; |
There was a problem hiding this comment.
Need to add a test for this scenario.
|
Here's is how the cache is going to look like from the local storage - a map between unit event keys and their TTL in milliseconds:
|
|
Re-opening it on #3287, this branch is from a forked repo so I think this is the cause of not allowing to run integration tests. |
2 participants
Description
Currently blocking SDK-1672 (#3257)
Introduces client-side caching for telemetry events. This prevents event flooding in frequently executed code paths, such as for React hooks or components.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change